Re: [PATCH] mtd: nand: pasemi: switch to pr_* functions

[Joe Perches]

On Fri, 2016-04-08 at 12:33 +0200, RafaÅ MiÅecki wrote:
> This patch also replaces %08llx with %08zx for printing resource start
> address. Old format was triggering:
> warning: format â%08llxâ expects type âlong long unsigned intâ, but argument 2 has type âresource_size_tâ

trivia:

> diff --git a/drivers/mtd/nand/pasemi_nand.c b/drivers/mtd/nand/pasemi_nand.c
[]
> @@ -112,8 +112,7 @@ static int pasemi_nand_probe(struct platform_device *ofdev)
> Â	/* Allocate memory for MTD device structure and private data */
> Â	chip = kzalloc(sizeof(struct nand_chip), GFP_KERNEL);
> Â	if (!chip) {
> -		printk(KERN_WARNING
> -		ÂÂÂÂÂÂÂ"Unable to allocate PASEMI NAND MTD device structure\n");
> +		pr_warn("Unable to allocate PASEMI NAND MTD device structure\n");

Maybe remove this unnecessary as there's an OOM stack dump.

> Â		err = -ENOMEM;
> Â		goto out;
> Â	}
> @@ -163,13 +162,13 @@ static int pasemi_nand_probe(struct platform_device *ofdev)
> Â	}
> Â
> Â	if (mtd_device_register(pasemi_nand_mtd, NULL, 0)) {
> -		printk(KERN_ERR "pasemi_nand: Unable to register MTD device\n");
> +		pr_err("pasemi_nand: Unable to register MTD device\n");

Maybe remove the embedded "pasemi_nand: " and add
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
before the first #include?

> Â		err = -ENODEV;
> Â		goto out_lpc;
> Â	}
> Â
> -	printk(KERN_INFO "PA Semi NAND flash at %08llx, control at I/O %x\n",
> -	ÂÂÂÂÂÂÂres.start, lpcctl);
> +	pr_info("PA Semi NAND flash at %08zx, control at I/O %x\n", res.start,
> +		lpcctl);

Maybe use %pR, &res instead of res.start?

	pr_info("PA Semi NAND flash at %pR, control at I/O %x\n",Â&res, lpcctl);