Re: [RFC PATCH] PM / wakeirq: fix wakeirq setting after wakup re-configuration from sysfs

From: Tony Lindgren
Date: Thu Apr 07 2016 - 13:56:13 EST


* Grygorii Strashko <grygorii.strashko@xxxxxx> [160406 04:47]:
> Now wakeirq stops working for device if wakeup option for
> this device will be reconfigured through sysfs, like:
>
> echo disabled > /sys/devices/platform/extcon_usb1/power/wakeup
> echo enabled > /sys/devices/platform/extcon_usb1/power/wakeup
>
> Once above set of commands is executed the device's wakeup_source
> opject will be recreated and dev->power.wakeup->wakeirq field will
> contain NULL. As result, device_wakeup_arm_wake_irqs() will not arm
> wakeirq for the affected device.
>
> Hece, lets try to fix it in the following way:
> check for dev->wakeirq field when device_wakeup_attach() is called
> and if !NULL re-attach wakeirq to the device

Yeah I think that's all there is to it, thanks for fixing it:

Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>