Re: [RFC PATCH v2 0/3] Add ACPI support for pinctrl configuration

From: Linus Walleij
Date: Thu Apr 07 2016 - 13:49:08 EST


On Thu, Apr 7, 2016 at 2:56 PM, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> On Tue, Apr 05, 2016 at 06:33:23PM +0300, Irina Tirdea wrote:

>> Changes from v1:
>> - address code review comments regarding coding style, documentation
>> and fixes
>> - rewrote patch 3 ("pinctrl: Parse GpioInt/GpioIo resources") to
>> avoid using triple pointers
>> - define pinconf_generic_dt_node_to_map since it is used by pinctrl
>> sirf driver
>> - add dependency on PINCONF_GENERIC to the entire ACPI parsing code
>> - dropped first patch from the series since it got merged
>> ("pinctrl: Rename pinctrl_utils_dt_free_map to pinctrl_utils_free_map")
>>
>> Irina Tirdea (3):
>> pinctrl: pinconf-generic: Add ACPI support
>> pinctrl: Add ACPI support
>> pinctrl: Parse GpioInt/GpioIo resources
>
> The series looks good to me now,
>
> Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
>
> Of course this all depends on the decision whether this is the preferred
> way of controlling and muxing pins in ACPI.

I think the discussion is very interesting and intense right now so
let us see. We need to form some rough consensus before we
know how to proceed.

Yours,
Linus Walleij