Re: [PATCH] phy: bcm-ns-usb2: new driver for USB 2.0 PHY on Northstar

From: Hauke Mehrtens
Date: Thu Apr 07 2016 - 12:33:47 EST


On 04/05/2016 09:34 PM, Jon Mason wrote:
>
>
> On Wed, Mar 30, 2016 at 5:32 PM, Jon Mason <jon.mason@xxxxxxxxxxxx
> <mailto:jon.mason@xxxxxxxxxxxx>> wrote:
>
> On Tue, Mar 29, 2016 at 10:01 AM, RafaÅ MiÅecki <zajec5@xxxxxxxxx
> <mailto:zajec5@xxxxxxxxx>> wrote:
>
> Northstar is a family of SoCs used in home routers. They have
> USB 2.0
> and 3.0 controllers with PHYs that need to be properly initialized.
> This driver provides PHY init support in a generic way and can
> be bound
> with an EHCI controller driver.
>
>
> Like the USB3 patch you just submitted for NS, this is a common IP
> block with NSP. I believe with some minor changes it can support
> both. Please allow me 1-2 days to look at these in more detail and
> see if I can get these patches working on NSP.
>
> Thanks,
> Jon
>
>
> After some internal discussion, I don't think this is going to work.
> This IP block is common for NS, NSP, and a few others. So binding it to
> BMCA is going to prevent us from being able to use it on any other
> platforms. However, a non-BMCA driver would still be usable by NS. So,
> I think that is a superior solution.
>
> We are currently in the process of getting a Phy driver out which would
> cover all the iProc SoCs. I think it is 1-2 weeks away from being
> submitted. So, I think to go forward we should use that one for NS.
> However, that does not bridge the gap until it is accepted.
>
> So, I think we have 2 options.
> 1. Wait for BCM to submit the iProc phy driver
> 2. Push this now, and remove it after the iProc phy driver is accepted.
>
> Thoughts?
>
> Thanks,
> Jon
>
Hi Jon,

As far as I see this does not have any build time dependency to bcma, it
only uses some header from bcma. Does this not build and run on your
devices without bcma?

Hauke