Re: [PATCH] usb: f_mass_storage: test whether thread is running before starting another

From: Alan Stern
Date: Thu Apr 07 2016 - 10:25:37 EST


On Thu, 7 Apr 2016, Michal Nazarewicz wrote:

> Sounds good to me. Iâd love someone to test this patch (I sadly have no
> way of doing that at the moment) and with that I can resend it with
> updated message.

Ivaylo should be able to try it.

> > BTW, is configfs capable of adding a single instance twice in different
> > configs? Or is that again something only legacy gadgets can do?
>
> I donât think so. I might be wrong though, but hereâs configuration
> from the original post:
>
> mkdir functions/mass_storage.0
> echo $file > functions/mass_storage.0/lun.0/file
> ln -s functions/mass_storage.0 configs/c.1
> ln -s functions/mass_storage.0 configs/c.2
>
> This makes me suspect itâs not possible to link a function instance to
> the same configuration twice, but now that I think about it, Iâm not
> quite sure what would happen if one did:
>
> ln -s functions/mass_storage.0 configs/c.1/foo
> ln -s functions/mass_storage.0 configs/c.1/bar

Do you think it would be worthwhile to check for this possibility in
the driver and report an error?

Alan Stern