Re: [PATCH 1/6] perf mem: Add --ldlat option

From: Jiri Olsa
Date: Thu Apr 07 2016 - 09:58:59 EST


On Sat, Mar 26, 2016 at 05:06:38PM +0100, Jiri Olsa wrote:
> On Thu, Mar 24, 2016 at 12:57:58PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Mar 24, 2016 at 01:52:15PM +0100, Jiri Olsa escreveu:
> > > Adding --ldlat option to specify desired latency
> > > for loads event.
> > >
> > > Specify 50 as loads event latency:
> > >
> > > $ perf mem record -e ldlat-loads -v --ldlat 50 true
> > > calling: record -W -d -e cpu/mem-loads,ldlat=50/P true
> >
> > We have all this infrastructure to set per-event settings, on the
> > command line, and here we end up adding a separate command line option
> > to do that? Why not something like:
> >
> > perf mem record -e ldlat-loads/lat=50/ true
>
> will check ;-)

sry for delay..

the thing is, that we can already do that via record command:
perf record -e "cpu/mem-loads,ldlat=30/" ls

but this option is in perf mem command, which provides
the way to use short config:
$ perf mem record --ldlat 50 ls

and adds also '-W -d' options for record command:

$ ./perf mem record -v --ldlat 50 ls
calling: record -W -d -e cpu/mem-loads,ldlat=50/P ls

jirka