Re: [PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs

From: Felipe Balbi
Date: Thu Apr 07 2016 - 01:07:25 EST



Hi,

before I review your patches, one comment

changbin.du@xxxxxxxxx writes:
> From: "Du, Changbin" <changbin.du@xxxxxxxxx>
>
> The first patch removed unnecessary checking for debugfs api call;
> The second patch fix a memory leak issue;
> The third patch add one new entry to debufs.
>
> Du, Changbin (3):
> usb: dwc3: make dwc3_debugfs_init return value be void

this is _not_ a fix

> usb: dwc3: free dwc->regset on dwc3_debugfs_exit

but this is. Why isn't this, at least, the first patch in the list ? In
fact, it would be preferred that this patch be sent by itself and the
following two patches should be on another branch completely without any
dependencies to the memory leak fix.

--
balbi

Attachment: signature.asc
Description: PGP signature