Re: [PATCH] cpufreq: Skip all governor-related actions for cpufreq_suspended set

From: Viresh Kumar
Date: Thu Apr 07 2016 - 00:28:27 EST


On 07-04-16, 03:29, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> Since governor operations are generally skipped if cpufreq_suspended
> is set, do nothing at all in cpufreq_start_governor() and
> cpufreq_exit_governor() in that case.
>
> In particular, this prevents fast frequency switching from being
> disabled after a suspend-to-RAM cycle on all CPUs except for the
> boot one.

static int cpufreq_governor(struct cpufreq_policy *policy, unsigned int event)
{
int ret;

/* Don't start any governor operations if we are entering suspend */
if (cpufreq_suspended)
return 0;

...

}

Above already guarantees that we would start/stop governors. Why do we
need this change then ?


--
viresh