Re: [PATCH 09/27] target: use bio_is_full()

From: Ming Lei
Date: Thu Apr 07 2016 - 00:07:14 EST


On Tue, Apr 5, 2016 at 9:02 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Tue, Apr 05, 2016 at 07:56:54PM +0800, Ming Lei wrote:
>> +++ b/drivers/target/target_core_pscsi.c
>> @@ -951,7 +951,7 @@ pscsi_map_sg(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents,
>> pr_debug("PSCSI: bio->bi_vcnt: %d nr_vecs: %d\n",
>> bio->bi_vcnt, nr_vecs);
>>
>> - if (bio->bi_vcnt > nr_vecs) {
>> + if (bio_is_full(bio)) {
>> pr_debug("PSCSI: Reached bio->bi_vcnt max:"
>> " %d i: %d bio: %p, allocating another"
>> " bio\n", bio->bi_vcnt, i, bio);
>
> This check should be removed entirely - bio_add_pc_page takes care of
> it.

OK.


--
Ming Lei