Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

From: Greg Kroah-Hartman
Date: Wed Apr 06 2016 - 20:07:30 EST


On Wed, Apr 06, 2016 at 01:19:04PM +0300, Felipe Balbi wrote:
> > What happened to getting internal help in designing this api? This
> > shouldn't be my job :)
>
> I looked at this Baolu but, at least to me, it's unclear what you're
> hinting here. Sure, the API is a bit odd in that we register a mux and
> unregister a device (that has been fixed), but is there anything else ?

I don't remember anymore, that was a few thousand emails ago...

But the suggestion about using devm_* shows that the original author has
very little understanding about how the driver model works at all, which
doesn't give me much hope at the moment...

greg k-h