Re: [PATCH v5 4/9] irqchip/gic-v2: Parse and export virtual GIC information

From: Julien Grall
Date: Wed Apr 06 2016 - 13:40:51 EST


Hi Christoffer,

On 06/04/2016 18:04, Christoffer Dall wrote:
On Mon, Apr 04, 2016 at 12:37:35PM +0100, Julien Grall wrote:
diff --git a/include/linux/irqchip/arm-gic-common.h b/include/linux/irqchip/arm-gic-common.h
new file mode 100644
index 0000000..ef34f6f
--- /dev/null
+++ b/include/linux/irqchip/arm-gic-common.h

just out of curiosity, why is include/linux/irqchip/arm-gic.h not
suitable?

Because arm-gic.h contains the definitions for GICv2 only. At least one of them is clashing with the GICv3 ones.

For instance, the function gic_send_sgi is defined statically the in GICv3 code, but exported for GICv2.

Regards,

--
Julien Grall