Re: [PATCH net-next v2 0/3] net: dsa: voidify STP setter and FDB/VLAN add ops

From: Andrew Lunn
Date: Wed Apr 06 2016 - 12:19:52 EST


On Wed, Apr 06, 2016 at 11:55:02AM -0400, Vivien Didelot wrote:
> Neither the DSA layer nor the bridge code (see br_set_state) really care
> about eventual errors from STP state setters, so make it void.
>
> The DSA layer separates the prepare and commit phases of switchdev in
> two different functions. Logical errors must not happen in commit
> routines, so make them void.

Looks good.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Thanks
Andrew