Re: [PATCH v2 09/30] Add tile-specific parity functions

From: Chris Metcalf
Date: Wed Apr 06 2016 - 09:28:10 EST


On 4/6/2016 5:08 AM, zengzhaoxiu@xxxxxxx wrote:
From: Zhaoxiu Zeng<zhaoxiu.zeng@xxxxxxxxx>

Signed-off-by: Zhaoxiu Zeng<zhaoxiu.zeng@xxxxxxxxx>
---
arch/tile/include/asm/bitops.h | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)

Since all the code you are adding here is architecture-independent,
I think it would make more sense to have it be in a file like
include/asm-generic/bitops/parity-popcount.h, which can then
be included from arch/tile/include/asm/bitops.h.

--
Chris Metcalf, Mellanox Technologies
http://www.mellanox.com