Re: Bug with paravirt ops and livepatches

From: Miroslav Benes
Date: Wed Apr 06 2016 - 04:43:16 EST


On Wed, 6 Apr 2016, Miroslav Benes wrote:

> Anyway I see there are some new comments on github. I'll look at those.
> But I'd prefer to discuss all the relevant things (that is kpatch
> unspecific) here. It would make it easier.

And you do (after seeing dates of the posts there), sorry for the noise.

Jessica, I think I am perfectly fine with introducing some arch-specific
code because of this problem.

We used generic apply_relocate_add() because it was a single
arch-independent entry point. There is no such things for paravirt_ops,
alternatives, jump labels and such things. In fact only module_finalize()
is there and that is not enough. So some arch-specific code in livepatch
seems to be unnecessary.

Cheers,
Miroslav