Re: [PATCH net-next 1/3] net: dsa: make the STP state function return void

From: Andrew Lunn
Date: Tue Apr 05 2016 - 19:47:20 EST


> -- port_stp_update: bridge layer function invoked when a given switch port STP
> +- port_stp_state: bridge layer function invoked when a given switch port STP

Hi Vivien

port_stp_state_set might be a better name, to make it clear it is
setting the state, not getting the current state, etc. Most of the
other functions are _add, _prepare, _join, _leave, so _set would fit
the pattern.

Changing to a void makes sense.

Andrew