Re: [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function call

From: Anna-Maria Gleixner
Date: Tue Apr 05 2016 - 05:39:25 EST


On Tue, 5 Apr 2016, Suzuki K. Poulose wrote:

> On 04/04/16 11:42, Anna-Maria Gleixner wrote:
> > Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to
> > hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and
> > CPU_DOWN_PREPARE are processed on the hotplugged cpu. Due to this SMP
> > function calls are no longer required.
> >
> > Replace smp_call_function_single() with a direct call of
> > hw_breakpoint_reset(). To keep the calling convention, interrupts are
> > explicitely disabled around the call.
>
> While you are at it, could you please also fix a similar instance
> in arch/arm64/kernel/debug-monitors.c: hw_breakpoint_reset_notify() ?

I already sent a patch for it, but I misspelled the arm mailinglist
address... I bounced it to the mailinglist.

Anna-Maria