Re: [PATCH v3 01/15] dmaengine: dw: fix master selection

From: Vinod Koul
Date: Mon Apr 04 2016 - 13:04:09 EST


On Fri, Mar 18, 2016 at 04:24:40PM +0200, Andy Shevchenko wrote:
> + /*
> + * We need controller-specific data to set up slave transfers.
> + */
> + BUG_ON(chan->private && !dw_dma_filter(chan, chan->private));

I don't think BUG_ON is apt here, gracefully failing and printing that can
be better..

--
~Vinod