Re: [PATCH v2 0/5] mempool based chained scatterlist alloc/free api

From: James Bottomley
Date: Mon Apr 04 2016 - 10:01:45 EST


On Sun, 2016-04-03 at 23:07 -0700, Ming Lin wrote:
> On Mon, Mar 28, 2016 at 7:48 AM, Ming Lin <mlin@xxxxxxxxxx> wrote:
> > On Thu, Mar 24, 2016 at 8:46 AM, James Bottomley
> > <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:
> > > On Thu, 2016-03-24 at 08:09 -0700, Ming Lin wrote:
> > > > On Wed, Mar 23, 2016 at 12:40 AM, Christoph Hellwig <hch@xxxxxx
> > > > >
> > > > wrote:
> > > > > On Tue, Mar 22, 2016 at 03:03:11PM -0700, Ming Lin wrote:
> > > > > > From: Ming Lin <ming.l@xxxxxxxxxxxxxxx>
> > > > > >
> > > > > > The fist 4 patches make the SG related
> > > > > > definitions/structs/functions
> > > > > > in SCSI code generic and the last patch move it to
> > > > > > lib/sg_pool.c.
> > > > > >
> > > > > > I still keep the macro "SG_MEMPOOL_NR" since it's used in 3
> > > > > > places.
> > > > >
> > > > > I don't Ñee the point, but I'm not going to block the series
> > > > > over
> > > > > it either.
> > > > >
> > > > > The new series looks really nice to me!
> > > > >
> > > > > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> > > >
> > > > Hi James,
> > > >
> > > > This series touches several sub-systems.
> > > > What's the best way to merge it?
> > >
> > > It has a minor intrusion into
> > >
> > > drivers/ata/pata_icside.c | 2 +-
> > > drivers/infiniband/ulp/srp/ib_srp.c | 4 +-
> > > drivers/usb/storage/scsiglue.c | 2 +-
> > >
> > > Apart from that, it's all SCSI, so the SCSI tree would seem to be
> > > the
> > > best one.
> >
> > Are you OK to merge it?
>
> Hi James,
>
> Ping ...
>
> Are you OK to apply this series?
> Or any changes needed?

It's got the needed reviews, but we need acks from tejun (ATA) and Sagi
(IB) and a repost fixing the test robot objection to patch 5.

James