Re: [PATCH 1/1] iio: gyro: bmg160: fix buffer read values

From: Jonathan Cameron
Date: Sun Apr 03 2016 - 06:23:48 EST


On 28/03/16 18:15, Irina Tirdea wrote:
> When reading gyroscope axes using iio buffers, the values
> returned are always 0. In the interrupt handler, the return
> value of the read operation is returned to the user instead
> of the value read. Return the value read to the user.
>
> This is also fixed in commit 82d8e5da1a33 ("iio:
> accel: bmg160: optimize transfers in trigger handler").
>
> Signed-off-by: Irina Tirdea <irina.tirdea@xxxxxxxxx>
Ouch. Applied and marked for stable.

Jonathan
> ---
> drivers/iio/gyro/bmg160_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/gyro/bmg160_core.c b/drivers/iio/gyro/bmg160_core.c
> index 295cf1d..e165ce9 100644
> --- a/drivers/iio/gyro/bmg160_core.c
> +++ b/drivers/iio/gyro/bmg160_core.c
> @@ -781,7 +781,7 @@ static irqreturn_t bmg160_trigger_handler(int irq, void *p)
> mutex_unlock(&data->mutex);
> goto err;
> }
> - data->buffer[i++] = ret;
> + data->buffer[i++] = val;
> }
> mutex_unlock(&data->mutex);
>
>