Re: [PATCH 02/13] fscrypto: rename some functions for clarity

From: Theodore Ts'o
Date: Sun Apr 03 2016 - 03:45:14 EST


On Sun, Apr 03, 2016 at 12:21:53AM -0500, Eric Biggers wrote:
> Rename fscrypt_complete() to page_crypt_complete(). This callback is
> specifically for data pages; fscrypto also performs filename encryption.
>
> Rename dir_crypt_complete() to fname_crypt_complete(). This callback is
> also used for symlink targets, not just directory entries.
>
> Rename fscrypt_process_policy() to fscrypt_set_policy(). The new name
> better matches the ioctl, and it goes along with fscrypt_get_policy().
>
> Signed-off-by: Eric Biggers <ebiggers3@xxxxxxxxx>

I'd really rather not renaming any globally visible functions until
after ext4 is converted over to use fs/crypto, just to avoid confusion.

Cheers,

- Ted