Re: [PART1 RFC v2 03/10] svm: Introduce new AVIC VMCB registers

From: Suravee Suthikulpanit
Date: Tue Mar 15 2016 - 08:52:27 EST




On 03/14/2016 07:25 PM, Paolo Bonzini wrote:


On 14/03/2016 08:41, Suravee Suthikulpanit wrote:
Any particular reason why you do not recommend the use of bit field?

1) The current coding style is generally not using bitfields

2) Having to review patches that change working code unrelated to AVIC

3) Most of the fields are not even used when AVIC is enabled, so the
benefit of the conversion is small.

Paolo


Ok I'll remove the bit-field stuff from patch 3 and will get rid off patch 4.

Thanks,
Suravee