Re: [PATCH v2 3/3] crypto: s5p-sss - Sort the headers to improve readability

From: Vladimir Zapolskiy
Date: Mon Mar 14 2016 - 18:36:13 EST


On 10.03.2016 03:31, Krzysztof Kozlowski wrote:
> Sort the headers alphabetically to improve readability and to spot
> duplications easier.
>
> Suggested-by: Vladimir Zapolskiy <vz@xxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
>
> ---
>
> Changes since v1:
> 1. New patch.
>
> My email differs from one used in previous patches because this time I
> am sending this from work.
> ---
> drivers/crypto/s5p-sss.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index bac1f4593f98..46fbeb933939 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -11,23 +11,23 @@
> *
> */
>
> +#include <linux/clk.h>
> +#include <linux/crypto.h>
> +#include <linux/dma-mapping.h>
> #include <linux/err.h>
> -#include <linux/module.h>
> -#include <linux/init.h>
> #include <linux/errno.h>
> +#include <linux/init.h>
> +#include <linux/interrupt.h>
> +#include <linux/io.h>
> #include <linux/kernel.h>
> -#include <linux/clk.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/scatterlist.h>
> -#include <linux/dma-mapping.h>
> -#include <linux/io.h>
> -#include <linux/of.h>
> -#include <linux/crypto.h>
> -#include <linux/interrupt.h>
>
> -#include <crypto/algapi.h>
> -#include <crypto/aes.h>
> #include <crypto/ctr.h>
> +#include <crypto/aes.h>
> +#include <crypto/algapi.h>
> #include <crypto/scatterwalk.h>
>
> #define _SBF(s, v) ((v) << (s))
>

Acked-by: Vladimir Zapolskiy <vz@xxxxxxxxx>

--
With best wishes,
Vladimir