Re: [PATCH v10 06/59] PCI: Kill wrong quirk about M7101

From: Linus Torvalds
Date: Fri Mar 11 2016 - 20:06:22 EST


On Fri, Mar 11, 2016 at 2:08 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>
> Maybe Linus could have some hint about that quirk?
>
> commit 34f550135e349102bd065488eabbbb217ab27f0d
> Author: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxx>
> Date: Fri Nov 23 15:32:20 2007 -0500
>
> Import 2.3.49pre2

Gah. That's marked as 2007, but that's an import of a much older
change, and 2.3.49 is way back in the last century.

But I looked at the datasheet for the M1543 PMU, and can confirm that
there's nothing at e0/e2 according to that datasheet. The PMU IO bases
show up at 0x10, and the SMB IO base at 0x14 in that doc..

Those kinds of things sometimes change between revisions, and it's
possible that there were versions that had them at that e0/e2 area,
and it got moved to the standard PCI BAR locations later.

I was definitely involved in these things, but my memory just doesn't
go back far enough to haev a clue what is going on. The only one I
remember working on myself was the PIIX4 one.

Removing it based on current datasheets and a failure of a known sparc
setup sounds reasonable.

Linus