Re: [RFC PATCH 1/3] siox: new driver/bus framework for Eckelmann SIOX

From: Greg Kroah-Hartman
Date: Fri Mar 11 2016 - 17:20:46 EST


On Fri, Mar 11, 2016 at 10:52:12PM +0100, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> drivers/Kconfig | 2 +
> drivers/Makefile | 1 +
> drivers/siox/Kconfig | 2 +
> drivers/siox/Makefile | 1 +
> drivers/siox/siox-core.c | 572 +++++++++++++++++++++++++++++++++++++++++++++++
> drivers/siox/siox.h | 48 ++++
> include/linux/siox.h | 53 +++++
> 7 files changed, 679 insertions(+)
> create mode 100644 drivers/siox/Kconfig
> create mode 100644 drivers/siox/Makefile
> create mode 100644 drivers/siox/siox-core.c
> create mode 100644 drivers/siox/siox.h
> create mode 100644 include/linux/siox.h

What's the relationship between your "master" and "regular" devices
here? I think that's getting things confused, you are unregistering
your 'master' yet the children it controls don't go away because you
never unregister them. You need to fix this heirachy up a bit, and
maybe just drop the 'master' logic?

thanks,

greg k-h