Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling events

From: Jiri Olsa
Date: Fri Mar 11 2016 - 13:15:12 EST


On Fri, Mar 11, 2016 at 10:48:14PM +0900, Namhyung Kim wrote:

SNIP

> > > > What about checking is_sampling_event() first and goto the last
> > > > paranoid_tracepoint_raw check instead? This way we can remove the
> > > > same check in the function trace case.
> > >
> > > right, will check
> >
> > hum, did you mean something like this?
> >
> > I'd rather keep it the original way.. seems more straight
>
> Hmm.. I think I was wrong. But it seems we can simply return 0 for
> non sampling case. How about this?

yep, that seems better.. will post v2

thanks,
jirka