Re: [PATCH-vs-togreg 1/2] iio: ina2xx-adc: update the CALIB. register when RShunt changes

[Marc Titinger]

On 11/03/2016 16:04, Andrew F. Davis wrote:
...

> > @@ -599,6 +621,8 @@ static const struct iio_info ina2xx_info = {
> >   	.debugfs_reg_access = ina2xx_debug_reg,
> >   };
> >
> > +
> > +
>
> ?

Ok, will fix in v2, thanks !

M.

> >   /* Initialize the configuration and calibration registers. */
> >   static int ina2xx_init(struct ina2xx_chip_info *chip, unsigned int config)
> >   {
> > @@ -609,17 +633,7 @@ static int ina2xx_init(struct ina2xx_chip_info *chip, unsigned int config)
> >   	if (ret)
> >   		return ret;
> >
> > -	/*
> > -	 * Set current LSB to 1mA, shunt is in uOhms
> > -	 * (equation 13 in datasheet). We hardcode a Current_LSB
> > -	 * of 1.0 x10-6. The only remaining parameter is RShunt.
> > -	 * There is no need to expose the CALIBRATION register
> > -	 * to the user for now.
> > -	 */
> > -	regval = DIV_ROUND_CLOSEST(chip->config->calibration_factor,
> > -				   chip->shunt_resistor);
> > -
> > -	return regmap_write(chip->regmap, INA2XX_CALIBRATION, regval);
> > +	return ina2xx_set_calibration(chip);
> >   }
> >
> >   static int ina2xx_probe(struct i2c_client *client,