Re: [RFC PATCH 2/2] KVM: MMU: return page fault error code from permission_fault

From: Paolo Bonzini
Date: Thu Mar 10 2016 - 09:05:14 EST




On 10/03/2016 15:03, Xiao Guangrong wrote:
>
>
> On 03/08/2016 07:45 PM, Paolo Bonzini wrote:
>> Intel's new PKU extension introduces a bit of the page fault error code
>> that must be dynamically computed after the PTE lookup (unlike I/D, U/S
>> and W/R). To ease this, these two patches make permission_fault return
>> the page fault error code.
>>
>> Right now it only adds the P bit to the input parameter "pfec", but PKU
>> can change that.
>
> Yep, i got the same idea when i reviewed the pkey patchset. This patch
> looks good to me.
>
> Reviewed-by: Xiao Guangrong <guangrong.xiao@xxxxxxxxxxxxxxx>

Great, feel free to pick it up in the pkey patchset. I'm answering to
1/2 now.

Paolo