Re: [PATCH 0/2] KVM: x86: disable MPX if host did not enable MPX XSAVE features

From: Paolo Bonzini
Date: Thu Mar 10 2016 - 07:31:06 EST




On 10/03/2016 13:28, Xiao Guangrong wrote:
>
>> Patch 1 ensures that all aspects of MPX are disabled when eager FPU
>> is disabled on the host. Patch 2 is just a cleanup.
>
> It looks good to me.
>
> Reviewed-by: Xiao Guangrong <guangrong.xiao@xxxxxxxxxxxxxxx>

Thanks very much!

> Now, more and more features depend on eger xsave, e.g, fpu, mpx and
> protection-key, maybe it is the time to rename eager-fpu to eager-xsave?

Yeah, that could be possible. You can propose it to Ingo Molnar (CCed).
If you change it in the general purpose kernel code, KVM will of course
follow suit.

Paolo