Re: [PATCH 0/3] nfit, libnvdimm, pmem: clear poison support

From: Verma, Vishal L
Date: Wed Mar 09 2016 - 18:05:11 EST


On Tue, 2016-03-08 at 14:47 -0800, Dan Williams wrote:
> ACPI 6.1 introduces the ability to send "clear error" commands to the
> ACPI0012:00 device representing the root of an "nvdimm bus".
>
> Similar to relocating a bad block on a disk, this support clears
> media errors in response to a write.
>
> ---
>
> Dan Williams (3):
> ÂÂÂÂÂÂnfit, libnvdimm: clear poison command support
> ÂÂÂÂÂÂlibnvdimm, pmem: fix kmap_atomic() leak in error path
> ÂÂÂÂÂÂlibnvdimm, pmem: clear poison on write
>
>
> Âarch/x86/include/asm/pmem.hÂÂÂÂÂÂ|ÂÂÂÂ5 +++
> Âdrivers/acpi/nfit.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ12 ++++++-
> Âdrivers/nvdimm/bus.cÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ65
> ++++++++++++++++++++++++++++++++++++++
> Âdrivers/nvdimm/nd.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂÂ2 +
> Âdrivers/nvdimm/pmem.cÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ40 ++++++++++++++++++++---
> Âinclude/linux/pmem.hÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ19 +++++++++++
> Âinclude/uapi/linux/ndctl.hÂÂÂÂÂÂÂ|ÂÂÂ13 ++++++++
> Âtools/testing/nvdimm/test/nfit.c |ÂÂÂ29 +++++++++++++++++
> Â8 files changed, 179 insertions(+), 6 deletions(-)

Except for the one comment in patch 1, this looks good to me!

For the series,
Reviewed-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>