Re: [PATCH 1/1] intel_pstate: Increase hold-off time before samples are scaled v2

From: kbuild test robot
Date: Tue Feb 23 2016 - 09:50:00 EST


Hi Mel,

[auto build test WARNING on pm/linux-next]
[also build test WARNING on next-20160223]
[cannot apply to v4.5-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url: https://github.com/0day-ci/linux/commits/Mel-Gorman/intel_pstate-Increase-hold-off-time-before-samples-are-scaled-v2/20160223-223212
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: i386-randconfig-x006-201608 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All warnings (new ones prefixed by >>):

drivers/cpufreq/intel_pstate.c: In function 'get_target_pstate_use_performance':
>> drivers/cpufreq/intel_pstate.c:957:49: warning: unused variable 'sample_ratio' [-Wunused-variable]
int32_t core_busy, max_pstate, current_pstate, sample_ratio;
^

vim +/sample_ratio +957 drivers/cpufreq/intel_pstate.c

63d1d656 Philippe Longepe 2015-12-04 941
63d1d656 Philippe Longepe 2015-12-04 942
e70eed2b Philippe Longepe 2015-12-04 943 /*
e70eed2b Philippe Longepe 2015-12-04 944 * The load can be estimated as the ratio of the mperf counter
e70eed2b Philippe Longepe 2015-12-04 945 * running at a constant frequency during active periods
e70eed2b Philippe Longepe 2015-12-04 946 * (C0) and the time stamp counter running at the same frequency
e70eed2b Philippe Longepe 2015-12-04 947 * also during C-states.
e70eed2b Philippe Longepe 2015-12-04 948 */
63d1d656 Philippe Longepe 2015-12-04 949 cpu_load = div64_u64(int_tofp(100) * mperf, sample->tsc);
e70eed2b Philippe Longepe 2015-12-04 950 cpu->sample.busy_scaled = cpu_load;
e70eed2b Philippe Longepe 2015-12-04 951
e70eed2b Philippe Longepe 2015-12-04 952 return cpu->pstate.current_pstate - pid_calc(&cpu->pid, cpu_load);
e70eed2b Philippe Longepe 2015-12-04 953 }
e70eed2b Philippe Longepe 2015-12-04 954
157386b6 Philippe Longepe 2015-12-04 955 static inline int32_t get_target_pstate_use_performance(struct cpudata *cpu)
93f0822d Dirk Brandewie 2013-02-06 956 {
c4ee841f Dirk Brandewie 2014-05-29 @957 int32_t core_busy, max_pstate, current_pstate, sample_ratio;
402c43ed Rafael J. Wysocki 2016-02-05 958 u64 duration_ns;
93f0822d Dirk Brandewie 2013-02-06 959
e0d4c8f8 Kristen Carlson Accardi 2014-12-10 960 /*
e0d4c8f8 Kristen Carlson Accardi 2014-12-10 961 * core_busy is the ratio of actual performance to max
e0d4c8f8 Kristen Carlson Accardi 2014-12-10 962 * max_pstate is the max non turbo pstate available
e0d4c8f8 Kristen Carlson Accardi 2014-12-10 963 * current_pstate was the pstate that was requested during
e0d4c8f8 Kristen Carlson Accardi 2014-12-10 964 * the last sample period.
e0d4c8f8 Kristen Carlson Accardi 2014-12-10 965 *

:::::: The code at line 957 was first introduced by commit
:::::: c4ee841f602e5eef8eab673295c49c5b49d7732b intel_pstate: add sample time scaling

:::::: TO: Dirk Brandewie <dirk.j.brandewie@xxxxxxxxx>
:::::: CC: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: Binary data