Re: [PATCH] Staging: comedi: mite: added spaces around | and *

[Ian Abbott]

On 23/02/16 00:37, Joe Perches wrote:
> On Tue, 2016-02-23 at 00:38 +0100, Philippe Loctaux wrote:
> > Added spaces around | and *, fixing 2 checkpatch checks.
> []
> > diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c
> []
> > @@ -51,7 +51,7 @@
> >
> >   #include "mite.h"
> >
> > -#define TOP_OF_PAGE(x) ((x)|(~(PAGE_MASK)))
> > +#define TOP_OF_PAGE(x) ((x) | (~(PAGE_MASK)))
>
> It'd be nice to remove superfluous parentheses here too
>
> +#define TOP_OF_PAGE(x) ((x) | ~PAGE_MASK)

Even better: just remove the macro, as it isn't used.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-