Re: [PATCH 1/8] tty: n_gsm: fix formatting errors

From: Andrej Krpic
Date: Mon Feb 22 2016 - 19:37:25 EST


On 21.02.2016 22:30, Joe Perches wrote:
On Sun, 2016-02-21 at 22:38 +0100, Andrej Krpic wrote:
Minor formatting changes to remove errors and reduce number of
warnings produced by checkpatch.pl script.
[]
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
[]
@@ -489,7 +490,8 @@ static void gsm_print_packet(const char *hdr, int addr, int cr,
 if (!(control & 0x01)) {
 pr_cont("I N(S)%d N(R)%d",
 (control & 0x0E) >> 1, (control & 0xE0) >> 5);
- } else switch (control & 0x0F) {
+ } else
+ switch (control & 0x0F) {

Please follow the brace rule for else uses where
if one branch has braces, the other does too.

Thank you for noticing.

Should I resend this as a single patch or wait for more comments for v2 series?


-Andrej