Re: [PATCH] clk: socfpga: allow for multiple parents on Arria10 periph clocks

From: Stephen Boyd
Date: Mon Feb 22 2016 - 16:50:35 EST


On 02/22, Stephen Boyd wrote:
> On 02/22, dinguyen@xxxxxxxxxxxxxxxxxxxxx wrote:
> > From: Dinh Nguyen <dinguyen@xxxxxxxxxxxxxxxxxxxxx>
> >
> > There are some Arria10 clocks of type "altr,socfpga-a10-perip-clk" that can
> > have multiple parents. Fix up the __socfpga_periph_init() to call
> > of_clk_parent_fill() that will return the appropriate number of parents.
> >
> > Also, update __socfpga_gate_init() to call of_clk_parent_fill() helper
> > function.
> >
> > Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxxxxxxxxxxxxx>
> > ---
>
> Applied to clk-next
>

Oops, spoke too soon:

drivers/clk/socfpga/clk-periph-a10.c:113:27: warning: incorrect type in assignment (different base types)
drivers/clk/socfpga/clk-periph-a10.c:113:27: expected char const *const *[assigned] parent_names
drivers/clk/socfpga/clk-periph-a10.c:113:27: got char const *( *<noident> )[5]
CC drivers/clk/socfpga/clk-periph-a10.o
drivers/clk/socfpga/clk-periph-a10.c: In function â__socfpga_periph_initâ:
drivers/clk/socfpga/clk-periph-a10.c:113:20: warning: assignment from incompatible pointer type [enabled by default]


--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project