Re: [PATCH 0/6] ARM: decompressor: several cleanups

From: Masahiro Yamada
Date: Mon Feb 22 2016 - 07:08:26 EST


Hi Russell,


2016-02-22 20:36 GMT+09:00 Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>:
> On Mon, Feb 22, 2016 at 04:31:11PM +0900, Masahiro Yamada wrote:
>> Masahiro Yamada (6):
>> ARM: decompressor: drop unneeded assignments to "targets"
>> ARM: decompressor: drop more unneeded assignments to "targets"
>> ARM: decompressor: use clean-files instead of extra-y to clean files
>> ARM: decompressor: drop redundant FORCE in Makefile
>> ARM: decompressor: merge piggy.*.S and simplify Makefile
>> ARM: decompressor: rename suffix_y to compress-y
>
> Most of this looks fine to me, but I've a question about how thoroughly
> patch 5 has been tested: iow, do we get correct behaviour if only the
> compression method is changed?
>
> Thanks.


I did build-test, changing the configuration
CONFIG_KERNEL_GZIP -> CONFIG_KERNEL_LZMA -> CONFIG_KERNEL_XZ -> ...

I confirmed zImage was created from the expected piggy.

For run-test, it worked fine too.



--
Best Regards
Masahiro Yamada