Re: [patch V2 13/28] x86/perf/intel_uncore: Clear all hardware state on exit

From: Thomas Gleixner
Date: Mon Feb 22 2016 - 07:00:39 EST


On Mon, 22 Feb 2016, Peter Zijlstra wrote:

> On Mon, Feb 22, 2016 at 11:06:52AM -0000, Thomas Gleixner wrote:
> > +static void __init uncore_exit_boxes(void *dummy)
> > +{
> > + struct intel_uncore_type **types = uncore_msr_uncores;
> > +
> > + while (*types)
> > + __uncore_exit_boxes(*types++, smp_processor_id());
>
> for (types = uncore_msr_uncores; *types; types++)
> __uncore_exit_boxes(*types, smp_processor_id());
>
> > +}
>
> You flipped to for() loops in the other places, figures this one should
> match?

Yes. Forgot about that one.