Re: [PATCH 2/2] bmips: add device tree example for BCM6358

[Ãlvaro FernÃndez Rojas]

El 20/01/2016 a las 17:59, Rob Herring escribió:
> On Sun, Jan 17, 2016 at 12:28:21PM +0100, Álvaro Fernández Rojas wrote:
> > This adds a device tree example for SFR Neufbox4 (Sercomm version), which
> > also serves as a real example for brcm,bcm6358-leds.
> >
> > Signed-off-by: Álvaro Fernández Rojas <noltari@xxxxxxxxx>
> [...]
>
> > diff --git a/arch/mips/boot/dts/brcm/bcm6358.dtsi
> b/arch/mips/boot/dts/brcm/bcm6358.dtsi
> > new file mode 100644
> > index 0000000..b2d11da
> > --- /dev/null
> > +++ b/arch/mips/boot/dts/brcm/bcm6358.dtsi
> > @@ -0,0 +1,111 @@
> > +/ {
> > +	#address-cells = <1>;
> > +	#size-cells = <1>;
> > +	compatible = "brcm,bcm6358";
> > +
> > +	cpus {
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		mips-hpt-frequency = <150000000>;
> > +
> > +		cpu@0 {
> > +			compatible = "brcm,bmips4350";
> > +			device_type = "cpu";
> > +			reg = <0>;
> > +		};
> > +
> > +		cpu@1 {
> > +			compatible = "brcm,bmips4350";
> > +			device_type = "cpu";
> > +			reg = <1>;
> > +		};
> > +	};
> > +
> > +	clocks {
> > +		periph_clk: periph_clk {
> > +			compatible = "fixed-clock";
> > +			#clock-cells = <0>;
> > +			clock-frequency = <50000000>;
> > +		};
> > +	};
> > +
> > +	aliases {
> > +		leds0 = &leds0;
> Why do we need alias for LEDs?
Okay, I will remove this, but you should know it was accepted for 
BCM6328 and BCM6368 too:
http://git.linux-mips.org/cgit/sjhill/linux-sjhill.git/commit/arch/mips/boot/dts/brcm?h=mips-for-linux-next&id=db66dbbbfd8ded204a97d090357aff582968fcf5
http://git.linux-mips.org/cgit/sjhill/linux-sjhill.git/commit/arch/mips/boot/dts/brcm?h=mips-for-linux-next&id=70ce14bfc9fdb9b6af84ac492e9d3311551618a5
> > +		uart0 = &uart0;
> > +		uart1 = &uart1;
> > +	};
> [...]
>
> > diff --git a/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts b/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts
> > new file mode 100644
> > index 0000000..ca95084
> > --- /dev/null
> > +++ b/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts
> > @@ -0,0 +1,47 @@
> > +/dts-v1/;
> > +
> > +/include/ "bcm6358.dtsi"
> > +
> > +/ {
> > +	compatible = "sfr,nb4-ser", "brcm,bcm6358";
> > +	model = "SFR Neufbox 4 (Sercomm)";
> > +
> > +	memory@0 {
> > +		device_type = "memory";
> > +		reg = <0x00000000 0x02000000>;
> > +	};
> > +
> > +	chosen {
> > +		bootargs = "console=ttyS0,115200";
> > +		stdout-path = &uart0;
> You shouldn't need both here. Just stdout-path.
Okay, I will use stdout-path only, but once again you should know that 
both are used on every bmips board:
https://github.com/torvalds/linux/tree/master/arch/mips/boot/dts/brcm
https://github.com/torvalds/linux/blob/master/arch/mips/boot/dts/brcm/bcm93384wvg.dts#L9
...
https://github.com/torvalds/linux/blob/master/arch/mips/boot/dts/brcm/bcm9ejtagprb.dts#L14
> Rob
Álvaro.