Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

From: Joe Perches
Date: Sat Feb 20 2016 - 19:03:25 EST


On Sat, 2016-02-20 at 12:17 -0600, Simon Quigley wrote:
> checkpatch.pl reported a warning of over 80 characters on line 1833
[]
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
[]
> @@ -1830,7 +1830,11 @@ static int iterate_inode_extrefs(u64 inum, struct btrfs_root *fs_root,
>   unsigned long ptr;
>  
>   while (1) {
> - ret = btrfs_find_one_extref(fs_root, inum, offset, path, &extref,
> + ret = btrfs_find_one_extref(fs_root,
> + inum,
> + offset,
> + path,
> + &extref,
>       &offset);

I think this is poor because all the arguments aren't aligned.

It'd be nicer like:

ret = btrfs_find_one_extref(fs_root, inum, offset, path,
&extref, &offset);