Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with struct resource

From: Jarkko Sakkinen
Date: Sat Feb 20 2016 - 03:04:30 EST


On Fri, Feb 19, 2016 at 10:44:34AM -0700, Jason Gunthorpe wrote:
> On Fri, Feb 19, 2016 at 05:06:06PM +0200, Jarkko Sakkinen wrote:
>
> > Can you quickly check the two top-most patches:
> >
> > https://github.com/jsakkine/linux-tpmdd/commits/master
>
> Drop the change to crb_map_res, the memset is not needed.

Left-over from when I tried to catch the issue. Removed.

> The shutdown change is probably OK for a rc fix, but it is still wrong.
> The shutdown has to be done inside the code after the core has removed
> all access to the tpm but before it has torn down so much that the
> driver doesn't work anymore.

I made the modifications you asked and run my smoke tests. Can I apply
your Reviewed-by's?

> Jason

/Jarkko