Re: [PATCH] rose: correct integer overflow check

From: David Miller
Date: Thu Feb 18 2016 - 15:33:37 EST


From: Insu Yun <wuninsu@xxxxxxxxx>
Date: Wed, 17 Feb 2016 15:25:13 -0500

> Since rose_ndevs is signed integer type,
> it can be overflowed when it is negative.
>
> Signed-off-by: Insu Yun <wuninsu@xxxxxxxxx>

That's not how the expression is evaluated.

Because of the types on the right hand side of the comparison
the expressions are all promoted to unsigned.

Did you look at the compiler's assembler output? I did when
reviewing your patch.