Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality

From: David Miller
Date: Thu Feb 18 2016 - 15:08:16 EST


From: Murali Karicheri <m-karicheri2@xxxxxx>
Date: Thu, 18 Feb 2016 12:13:10 -0500

> On 02/16/2016 03:24 PM, David Miller wrote:
>>
>> I would like some of the feedback to be taken into consideration and
>> integrated into this patch.
>>
>> Part of the reason this regression was introduced was probably because
>> the purpose of some fields or descriptor semantics was not defined
>> properly.
>>
>> Therefore it is absolutely appropriate to properly name and document
>> these fields as part of the bug fix.
>>
>> Thank you.
>>
> David,
>
> I will take over this from Grygorii as he is out of office.
>
> I propose to keep this patch as is and add additional patch to address
> the feedback in the same series (v1). Is that fine with you?

No, I want the code to be clarified along with the bug fix so that
this bug is unlikely to resurface.