Re: [PATCH] signals, ia64, mips: update arch-specific siginfos with pkeys field

From: Ingo Molnar
Date: Thu Feb 18 2016 - 05:15:49 EST



* Dave Hansen <dave@xxxxxxxx> wrote:

>
> This fixes a compile error that Ingo was hitting with MIPS when the
> x86 pkeys patch set is applied.
>
> ia64 and mips have separate definitions for siginfo from the
> generic one. Patch them to have the pkey fields.
>
> Note that this is exactly what we did for MPX as well.
>
> Signed-off-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> Cc: linux-mips@xxxxxxxxxxxxxx
> Cc: linux-ia64@xxxxxxxxxxxxxxx
> ---
>
> b/arch/ia64/include/uapi/asm/siginfo.h | 13 +++++++++----
> b/arch/mips/include/uapi/asm/siginfo.h | 13 +++++++++----
> 2 files changed, 18 insertions(+), 8 deletions(-)

This solved the MIPS and IA64 build problems, but there's still one bug left: UML
does not build:

/home/mingo/tip/mm/gup.c: In function âcheck_vma_flagsâ:
/home/mingo/tip/mm/gup.c:456:2: error: implicit declaration of function âarch_vma_access_permittedâ [-Werror=implicit-function-declaration]
if (!arch_vma_access_permitted(vma, write, false, foreign))
[...]

Please send a delta patch for this too.

Thanks,

Ingo