Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110

From: MichaÅ KÄpieÅ
Date: Thu Feb 18 2016 - 03:25:36 EST


> > Please note that except for the first 5 entries, the keymap is sorted by
> > event code in ascending order.
>
> I have prepared some patches which sort all event codes plus adds
> missing comments... So after all dell patches are in Darren tree, I will
> rewrite/rebase my and can send them.
>
> > If I understand correctly, doing what you ask would break that ordering:
> >
> > /* Dell Instant Launch key */
> > { KE_KEY, 0xe025, { KEY_PROG4 } },
> > { KE_KEY, 0xe029, { KEY_PROG4 } },
> >
> > /* Audio panel key */
> > { KE_IGNORE, 0xe026, { KEY_RESERVED } },
> >
> > Is this acceptable? Or perhaps you had something else on your mind?
>
> Thats better, now we know which event is audio and which launch key.

Ok, then I will do that in v4.

--
Best regards,
MichaÅ KÄpieÅ