Re: [PATCH v2 2/3] ARM: dts: vf-colibri: add basic supply regulators

From: Stefan Agner
Date: Wed Feb 17 2016 - 16:54:48 EST


On 2016-02-16 16:28, Fabio Estevam wrote:
> On Tue, Feb 16, 2016 at 10:18 PM, Stefan Agner <stefan@xxxxxxxx> wrote:
>
>> + reg_module_3v3: regulator-module-3v3 {
>> + compatible = "regulator-fixed";
>> + regulator-name = "+V3.3";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-always-on;
>
> This 'regulator-always-on' property can be removed.
>
>> + };
>> +
>> + reg_module_3v3_avdd: regulator-module-3v3-avdd {
>> + compatible = "regulator-fixed";
>> + regulator-name = "+V3.3_AVDD_AUDIO";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-always-on;
>
> Same here.

Hm, should I remove them also in Patch 1/3? It's a fixed regulator too,
hence I guess regulator-always-on is pointless there too...?

--
Stefan