Re: [PATCH v2] usb: storage: use usb_store_dbg instead of US_DEBUGPX

[Greg Kroah-Hartman]

On Wed, Feb 17, 2016 at 10:42:37AM -0800, Victor Dodon wrote:
> The US_DEBUGPX macro uses printk without specifying a kernel log level, so
> the default kernel log level is used, which may not match LOGLEVEL_DEBUG
> used in usb_stor_dbg. Remove the macro and use usb_store_dbg instead.
> 
> Signed-off-by: Victor Dodon <printesoi@xxxxxxxxxxxx>
> --
> Changes in v2:
>   - Completely remove the macro instead of using printk_emit
>   - Change all uses of US_DEBUGPX to usb_stor_dbg

Great!  Now can you get rid of the horrid USB_DEBUG() macro as well?  I
don't think that's really needed anymore (the frecom driver's usage can
just be removed entirely).

thanks,

greg k-h