Re: [PATCH net-next] net: bridge: log port STP state on change

From: Stephen Hemminger
Date: Tue Feb 16 2016 - 23:27:29 EST


On Tue, 16 Feb 2016 10:09:51 -0500
Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx> wrote:

> Remove the shared br_log_state function and print the info directly in
> br_set_state, where the net_bridge_port state is actually changed.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>
> ---

Looks good and fixes the weird case where set_state fails then a log
message would still be printed.