Re: [PATCH v4 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port

From: Arnd Bergmann
Date: Tue Feb 16 2016 - 16:21:55 EST


On Tuesday 16 February 2016 19:14:53 Gregory CLEMENT wrote:
>
> +config SERIAL_MVEBU_UART
> + bool "Marvell EBU serial port support"
> + select SERIAL_CORE

It would be nice to make this a tristate option with

depends on ARCH_MVEBU || COMPILE_TEST

so we can build it in an allmodconfig kernel as a standalone module
like the other drivers.

> +
> +config SERIAL_MVEBU_CONSOLE
> + bool "Console on Marvell EBU serial port"
> + depends on SERIAL_MVEBU_UART

then this one must become

depends on SERIAL_MVEBU_UART

so it does not get enabled if the driver is not builtin.

Arnd