[PATCH 1/3] coccinelle: also catch kzfree() issues

From: Yann Droneaud
Date: Tue Feb 16 2016 - 12:52:27 EST


Since commit 3ef0e5ba4673 ('slab: introduce kzfree()'),
kfree() is no more the only function to be considered.

Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
Signed-off-by: Yann Droneaud <ydroneaud@xxxxxxxxxx>
---
scripts/coccinelle/free/devm_free.cocci | 2 ++
scripts/coccinelle/free/kfree.cocci | 3 +++
scripts/coccinelle/free/kfreeaddr.cocci | 6 +++++-
3 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/scripts/coccinelle/free/devm_free.cocci b/scripts/coccinelle/free/devm_free.cocci
index 3d9349012bb3..83c03adec1c5 100644
--- a/scripts/coccinelle/free/devm_free.cocci
+++ b/scripts/coccinelle/free/devm_free.cocci
@@ -48,6 +48,8 @@ position p;
(
* kfree@p(x)
|
+* kzfree@p(x)
+|
* free_irq@p(x)
|
* iounmap@p(x)
diff --git a/scripts/coccinelle/free/kfree.cocci b/scripts/coccinelle/free/kfree.cocci
index 577b78056990..c3246b47f51f 100644
--- a/scripts/coccinelle/free/kfree.cocci
+++ b/scripts/coccinelle/free/kfree.cocci
@@ -16,6 +16,7 @@ virtual org
virtual report

@free@
+identifier kfree =~ "kz?free";
expression E;
position p1;
@@
@@ -54,6 +55,7 @@ position p;
sizeof(<+...E@xxxx+>)

@loop exists@
+identifier kfree =~ "kz?free";
expression E;
identifier l;
position ok;
@@ -67,6 +69,7 @@ while (1) { ...
}

@r exists@
+identifier kfree =~ "kz?free";
expression free.E, subE<=free.E, E2;
expression E1;
iterator iter;
diff --git a/scripts/coccinelle/free/kfreeaddr.cocci b/scripts/coccinelle/free/kfreeaddr.cocci
index ce8aacc314cb..d46063b1db8b 100644
--- a/scripts/coccinelle/free/kfreeaddr.cocci
+++ b/scripts/coccinelle/free/kfreeaddr.cocci
@@ -16,7 +16,11 @@ identifier f;
position p;
@@

+(
* kfree@p(&e->f)
+|
+* kzfree@p(&e->f)
+)

@script:python depends on org@
p << r.p;
@@ -28,5 +32,5 @@ cocci.print_main("kfree",p)
p << r.p;
@@

-msg = "ERROR: kfree of structure field"
+msg = "ERROR: invalid free of structure field"
coccilib.report.print_report(p[0],msg)
--
2.5.0