Re: [PATCH] drivers/hwtracing: make coresight-* explicitly non-modular

From: Mathieu Poirier
Date: Tue Feb 16 2016 - 10:24:57 EST


On 16 February 2016 at 03:15, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:
> On Mon, Feb 15, 2016 at 06:25:56PM -0700, Mathieu Poirier wrote:
>> On 14 February 2016 at 10:19, Paul Gortmaker
>> <paul.gortmaker@xxxxxxxxxxxxx> wrote:
>> > diff --git a/include/linux/amba/bus.h b/include/linux/amba/bus.h
>> > index 9006c4e75cf7..3d8dcdd1aeae 100644
>> > --- a/include/linux/amba/bus.h
>> > +++ b/include/linux/amba/bus.h
>> > @@ -163,4 +163,13 @@ struct amba_device name##_device = { \
>> > #define module_amba_driver(__amba_drv) \
>> > module_driver(__amba_drv, amba_driver_register, amba_driver_unregister)
>> >
>> > +/*
>> > + * builtin_amba_driver() - Helper macro for drivers that don't do anything
>> > + * special in driver initcall. This eliminates a lot of boilerplate. Each
>> > + * driver may only use this macro once, and calling it replaces the instance
>> > + * device_initcall().
>> > + */
>> > +#define builtin_amba_driver(__amba_drv) \
>> > + builtin_driver(__amba_drv, amba_driver_register)
>> > +
>> > #endif
>> > --
>> > 2.6.1
>> >
>>
>> I'm good with this patch on the CS side but Russell maintains the amba
>> subsystem and as such needs to agree with the new macro. Russell, I
>> offer to take this through my tree if you're fine with the changes.
>
> Acked-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
>

Applied - thanks.

> --
> RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
> according to speedtest.net.