Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386

From: Arnd Bergmann
Date: Tue Feb 16 2016 - 06:02:28 EST


On Tuesday 16 February 2016 10:08:14 Vladimir Murzin wrote:
> +
> + ethernet@40200000 {
> + compatible = "smsc,lan9220", "smsc,lan9115";
> + reg = <0x40200000 0x10000>;
> + interrupts = <13>;
> + interrupt-parent = <&nvic>;
> + smsc,irq-active-high;
> + };
> +};
> +
>

This node seems slightly misplaced. Is there some external bus interface
that this is connected to? The address suggests that it should be somewhere
below the /soc node, and you probably want to list the external bus
interface with a "ranges" property that identifies the addresses visibile
there, and put the external chip under there.

Arnd