RE: [PATCH v11 1/1] efi: a misc char interface for user to update efi firmware

From: Kweh, Hock Leong
Date: Mon Feb 15 2016 - 01:46:45 EST


> -----Original Message-----
> From: Matt Fleming [mailto:matt@xxxxxxxxxxxxxxxxx]
> Sent: Monday, February 08, 2016 11:14 PM
>
> On Fri, 29 Jan, at 12:39:54PM, Kweh Hock Leong wrote:
> > From: "Kweh, Hock Leong" <hock.leong.kweh@xxxxxxxxx>
> >
> > Introducing a kernel module to expose capsule loader interface
> > (misc char device file note) for users to upload capsule binaries.
> >
> > Example:
> > cat firmware.bin > /dev/efi_capsule_loader
> >
> > This patch also export efi_capsule_supported() function symbol for
> > verifying the submitted capsule header in this kernel module.
> >
> > Cc: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Kweh, Hock Leong <hock.leong.kweh@xxxxxxxxx>
> > ---
> > drivers/firmware/efi/Kconfig | 9 +
> > drivers/firmware/efi/Makefile | 1 +
> > drivers/firmware/efi/capsule-loader.c | 334
> +++++++++++++++++++++++++++++++++
> > drivers/firmware/efi/capsule.c | 1 +
> > 4 files changed, 345 insertions(+)
> > create mode 100644 drivers/firmware/efi/capsule-loader.c
>
> OK, I've picked this up. I did make some modifications based on
> Bryan's comments from v10 of this patch.
>
> You can see a diff of the changes below, but roughly,
>
> 1. Use Bryan's comments for changelog and expand it a bit
> 2. Add more detail to Kconfig entry, most people don't need this
> 3. Sprinkled comments from Bryan in the kerneldoc comments
> 4. Deleted a level of indentation in efi_capsule_setup_info()
> 5. Local variable instead of indexing ->pages in efi_capsule_write()
> 6. Fix memory leak in efi_capsule_open()
>
> My plan is to include this patch in the EFI capsule series, and resend
> the whole thing out.
>

Thank Matt and also appreciate others who helped on reviewing, testing
as well as provided design idea.


Thanks & Regards,
Wilson